View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000046 | Aardvark Bugs | Aardvark Mk III | public | 2009-06-25 11:49 | 2009-07-01 15:19 |
| Reporter | Don Cragun | Assigned To | |||
| Priority | normal | Severity | Comment | Type | Omission |
| Status | Closed | Resolution | Accepted As Marked | ||
| Name | Don Cragun | ||||
| Organization | Self | ||||
| User Reference | |||||
| Summary | 0000046: Missing Field for Accept as Marked bugs? | ||||
| Description | Should there be an additional field next to the "Resolution" field on a bug report that would be set to point to the accepted text when the Resolution field value is "Accepted As Marked"? Without this added field, it seems that what has been accepted might not remain clear if there is an on-going discussion about proposed changes. It may also be needed if the interpretation process changes text that had been accepted as submitted. | ||||
| Desired Action | Add a field to bug reports with a label "Accepted Text" with possible values being "Desired Action", "Note being added by this update", or "Note XXXXXXX" (where XXXXXXX is the sequence number of an existing note that contains the approved text). It should default to "Desired Action" until another note is designated as the accepted text. | ||||
| Tags | No tags attached. | ||||
|
|
Don, this is a good catch - we do need some clear way of designating where the "accepted as marked" stuff is. I'm not going to go live until I figure this out out as it may affect the DB. |
|
|
Added a new field, "Final Accepted Text", with at default value of "Desired Action". This field is only editable by Manager-level users (ORs & Andrew). You can find it right above the "Summary" line. |
|
|
This looks good. (Although it would be nicer if the "Final Accepted Text" field appeared closer on the bug display to the "Resolution" field.) Hoever, I have a couple of questions: 1. Shouldn't the default value be "" and only be filled in when the Resolution is changed to "Accepted As Marked"? 2. When using advanced search, if I set it up to look for Final Accepted Text value "Desired Action" and Resolution value "Accepted As Marked", I get 0 matches even though 0000052 should match as explained by 0000052:0000092. |
|
|
Upon closer inspection, it looks like the search I mentioned in 0000046:0000112 question #2 may be because the default value is "DesiredAction" instead of "Desired Action". Since the search choices don't give you the option of choosing the string without the <space>, no matches are found. |
|
|
Hmm. My reasoning was that the default value should be the Desired Action - that way we wouldn't have to change it for "most" cases. There is a known Mantis defect where filtering Custom Fields breaks when the selection has spaces, don't know if that is hitting us here. I do see that selecting "none" for Final Accepted Text acts as if you are seaching for the default string. |
|
|
I changed the default text to "DesiredAction" as a first step towards correcting this problem. I'm leaving this bug open for now. |
|
|
My reason for thinking the default text should be an empty string is that I think it may lead readers to believe that the Desired Text contents have been approved even though the bug Resolution is something like "Open" or "Rejected". |
|
|
I've set the default for this field to the empty string. This also works well with the "none" filter for this field. We can re-open if we want to revisit this. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-06-25 11:49 | Don Cragun | New Issue | |
| 2009-06-25 11:49 | Don Cragun | Name | => Don Cragun |
| 2009-06-25 19:57 | msbrown | Note Added: 0000100 | |
| 2009-06-25 19:57 | msbrown | Status | New => Under Review |
| 2009-06-26 07:36 | msbrown | Note Added: 0000109 | |
| 2009-06-26 07:36 | msbrown | Status | Under Review => Resolution Proposed |
| 2009-06-26 07:36 | msbrown | Resolution | Open => Accepted As Marked |
| 2009-06-26 10:03 | Don Cragun | Note Added: 0000112 | |
| 2009-06-26 10:08 | Don Cragun | Note Edited: 0000112 | |
| 2009-06-26 11:19 | Don Cragun | Note Added: 0000113 | |
| 2009-06-26 12:14 | msbrown | Note Added: 0000115 | |
| 2009-06-26 12:30 | msbrown | Note Added: 0000118 | |
| 2009-06-26 12:47 | Don Cragun | Note Added: 0000119 | |
| 2009-06-26 13:31 | msbrown | Note Added: 0000120 | |
| 2009-06-26 13:31 | msbrown | Status | Resolution Proposed => Resolved |
| 2009-06-29 14:53 | msbrown | Status | Resolved => Closed |
| 2009-07-01 15:19 | Don Cragun | Organization | => Self |